Skip to content

🐛Refreshing shall renew the socket #8228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 19, 2025
Merged

🐛Refreshing shall renew the socket #8228

merged 6 commits into from
Aug 19, 2025

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Aug 18, 2025 •
edited
Loading

What do these changes do?

Fix the issue where when the maximal amount of session was reached, refreshing a tab would throw the user out of the project

driving tests:

  • test_refreshing_tab_of_opened_project_multiple_users
  • test_closing_and_reopening_tab_of_opened_project_multiple_users

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Voyager milestone Aug 18, 2025
@sanderegg sanderegg self-assigned this Aug 18, 2025
@sanderegg sanderegg added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Aug 18, 2025
@codecov
Copy link

codecov bot commented Aug 18, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.35%. Comparing base (e8383ed) to head (a19fb27).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8228      +/-   ##
==========================================
- Coverage   88.05%   85.35%   -2.71%     
==========================================
  Files        1915      742    -1173     
  Lines       73880    34182   -39698     
  Branches     1300      175    -1125     
==========================================
- Hits        65056    29175   -35881     
+ Misses       8432     4950    -3482     
+ Partials      392       57     -335
Flag Coverage Δ
integrationtests 64.04% <0.00%> (-0.07%) ⬇️
unittests 87.38% <100.00%> (+0.69%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.90% <ø> (-8.14%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.04% <ø> (-12.85%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 87.13% <ø> (-2.92%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 88.14% <100.00%> (-0.05%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8383ed...a19fb27. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for a19fb27.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on base branch Retries 🔍 CI Insights 📄 Logs
CI [sys] public api (3.11, ubuntu-24.04) Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
system-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@sanderegg sanderegg force-pushed the bugfix/refresh-socket branch from eed0530 to 33df8d1 Compare August 19, 2025 05:39
@sanderegg sanderegg force-pushed the bugfix/refresh-socket branch from 33df8d1 to eaa2ff2 Compare August 19, 2025 06:07
@sanderegg sanderegg marked this pull request as ready for review August 19, 2025 08:20
odeimaiz
odeimaiz approved these changes Aug 19, 2025
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, thanks!

matusdrobuliak66
matusdrobuliak66 approved these changes Aug 19, 2025
View reviewed changes
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool thanks

GitHK
GitHK approved these changes Aug 19, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sanderegg
Copy link
Member Author

sanderegg commented Aug 19, 2025

@mergify queue

@sanderegg sanderegg added the 🤖-automerge marks PR as ready to be merged for Mergify label Aug 19, 2025
@mergify
Copy link
Contributor

mergify bot commented Aug 19, 2025 •
edited
Loading

queue

🛑 Configuration not compatible with a branch protection setting

The branch protection setting Require branches to be up to date before merging is not compatible with max_parallel_checks>1, queue_conditions != merge_conditions and must be unset.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 19, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sanderegg sanderegg merged commit b0784c9 into ITISFoundation:master Aug 19, 2025
92 of 95 checks passed
@sanderegg sanderegg deleted the bugfix/refresh-socket branch August 19, 2025 09:36
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 2, 2025
Closed
61 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 18, 2025
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov is a code owner

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@sanderegg sanderegg

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

Voyager

Development

Successfully merging this pull request may close these issues.

Sometimes refreshing a collaborative project tab prevents the user to enter the project

4 participants

@sanderegg @GitHK @odeimaiz @matusdrobuliak66